Dor1s added a comment.
Thanks a lot, Vedant! No worries, I'll commit it on behalf of Yuke @liaoyuke
Repository:
rC Clang
https://reviews.llvm.org/D45178
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
vsk accepted this revision.
vsk added a comment.
Lgtm, thank you.
If you don't have commit access, let us know, and somebody will commit this on
your behalf.
Repository:
rC Clang
https://reviews.llvm.org/D45178
___
cfe-commits mailing list
cfe-
vsk added a comment.
I'd like to test this out a bit more. Could you wait one more day?
Repository:
rC Clang
https://reviews.llvm.org/D45178
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Dor1s added a comment.
Friendly ping. We'll probably land it tomorrow anyway, as it blocks another fix
needed for llvm-cov, but having another pair of eyes to look at this would be
still helpful :)
Repository:
rC Clang
https://reviews.llvm.org/D45178
_
Dor1s accepted this revision.
Dor1s added a comment.
This revision is now accepted and ready to land.
Looks good from my perspective, added Peter and Zachary who might know this
code better :)
Repository:
rC Clang
https://reviews.llvm.org/D45178
___
liaoyuke updated this revision to Diff 140672.
liaoyuke added a comment.
Fix styles.
Repository:
rC Clang
https://reviews.llvm.org/D45178
Files:
lib/Basic/VirtualFileSystem.cpp
unittests/Basic/VirtualFileSystemTest.cpp
Index: unittests/Basic/VirtualFileSystemTest.cpp
==
liaoyuke created this revision.
Herald added subscribers: cfe-commits, mgrang.
In https://reviews.llvm.org/D44960, file status check is executed every
time a real file system directory iterator is constructed or
incremented, and emits an error code. This change list fixes the errors
in VirtualFile
