[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

NoQ added a comment. Yup thanks!~ Repository: rC Clang https://reviews.llvm.org/D45407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

This revision was automatically updated to reflect the committed changes. Closed by commit rL330766: [analyzer] Add support for the note diagnostic pieces to plist output format. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

This revision was automatically updated to reflect the committed changes. Closed by commit rC330766: [analyzer] Add support for the note diagnostic pieces to plist output format. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D45407 Files:

[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

Szelethus added a comment. Can someone commit this for me? I don't have a write access. Repository: rC Clang https://reviews.llvm.org/D45407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Checked this out, seems to be safely ignored for now. The `.plist` format is pretty resistant to this sort of stuff because most APIs to handle it are almost treating it as native

[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

whisperity added a comment. @NoQ The problem with emitting notes as events is that we lose the information that the node was a `node`. How does Xcode behave with these notes? Does it ignore them, or can read them from the command-line output of the analyser? Repository: rC Clang

[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

Szelethus added a comment. I just had a look with `-analyzer-config notes-as-events=true`, and it works (with CodeChecker, at least). I'd still implement a better support for notes, but this is a great workaround for now. Thanks! Repository: rC Clang https://reviews.llvm.org/D45407

[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

Szelethus added a comment. > Btw, what sort of UI are you trying to make these extra note pieces of mine > work with? I'm also developing a checker: https://reviews.llvm.org/D45532. This checker emits very important information in notes. When I tried testing it with Ericsson's CodeChecker, I

[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

NoQ added a comment. Sorry, overwhelmed a bit, i'll try to get to this as soon as possible. Btw, what sort of UI are you trying to make these extra note pieces of mine work with? Was `-analyzer-config notes-as-events=true` of any help? Repository: rC Clang https://reviews.llvm.org/D45407

[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

Szelethus added a comment. Did you have some time to check on those programs? :) Repository: rC Clang https://reviews.llvm.org/D45407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

Szelethus added a comment. Thanks! Repository: rC Clang https://reviews.llvm.org/D45407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

NoQ added a comment. The output looks reasonable to me, but we'll need to see if other consumers of the plist output (IDEs that supports the analyzer, such as Xcode) will be able to accept the modified output (at least, will be able to ignore it). I'll have a look. Repository: rC Clang

[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

Szelethus created this revision. Szelethus added reviewers: dergachev.a, xazax.hun. Szelethus added a project: clang. Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet, whisperity. Herald added a reviewer: george.karpenkov. Added notes to `-analyzer-output=plist`. Repository: