This revision was automatically updated to reflect the committed changes.
Closed by commit rL329594: [cmake] Include LLVMTestingSupport when doing
stand-alone build (authored by mgorny, committed by ).
Herald added subscribers: llvm-commits, klimek.
Changed prior to commit:
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE329594: [cmake] Include LLVMTestingSupport when doing
stand-alone build (authored by mgorny, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D45409
Files:
unittests/CMakeLists.txt
mgorny added a comment.
I've based this change on an earlier fix to lldb when that project started
using LLVMTestingSupport.
That change in turn was based on how we handle gtest across the projects. As
for gtest, I think installing was not considered as an option since different
projects may
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
This seems fine to me too to fix the immediate issue.
Personally I'd rather drop our usage of llvmtestingsupport as it provides
marginal value anyway. But also happy to do this as a
ilya-biryukov added a subscriber: sammccall.
ilya-biryukov added a comment.
This LG to fix the standalone build.
However, why not install LLVMTestingSupport in llvm? It feels that we should
either include it or disable the tests for standalone builds. And disabling the
tests seems wrong.
WDYT?
mgorny created this revision.
mgorny added reviewers: simark, ilya-biryukov.
Herald added a subscriber: ioeric.
Explicitly include and build lib/Testing/Support from LLVM sources when
doing a stand-alone build. This is necessary since clangd tests started
to depend on LLVMTestingSupport library
