This revision was automatically updated to reflect the committed changes.
Closed by commit rC329784: [Tooling] Optimize memory usage in
InMemoryToolResults. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45479?vs=141842=141956#toc
Repository:
rC
hokein updated this revision to Diff 141842.
hokein edited the summary of this revision.
hokein added a comment.
Add a comment.
Repository:
rC Clang
https://reviews.llvm.org/D45479
Files:
include/clang/Tooling/Execution.h
lib/Tooling/AllTUsExecution.cpp
lib/Tooling/Execution.cpp
sammccall added inline comments.
Comment at: include/clang/Tooling/Execution.h:55
class InMemoryToolResults : public ToolResults {
public:
please add a high-level comment explaining what this is caching and when we
expect it to work well.
Repository:
ilya-biryukov added a comment.
This definitely helps with memory consumption of clangd's
global-symbol-indexer, I can now run it over LLVM on MacBook without it
swapping out of RAM. The physical memory usage goes up to 3GB at some point,
before it was > 20GB.
Strictly speaking, interning the
