This revision was automatically updated to reflect the committed changes.
Closed by commit rL330004: [clangd] Match AST and Index label for template
Symbols (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D45482
ilya-biryukov added inline comments.
Comment at: unittests/clangd/FileIndexTests.cpp:218
+ EXPECT_EQ(Sym.CompletionLabel, "vector");
+ EXPECT_EQ(Sym.CompletionSnippetInsertText, "vector<${1:class Ty}>");
+ SeenVector = true;
sammccall wrote:
> If
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE330004: [clangd] Match AST and Index label for template
Symbols (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45482?vs=142372=142373#toc
Repository:
rL
ilya-biryukov updated this revision to Diff 142372.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Also test plain text completion text
- Clarify the comment
- Simplify conditions in getTemplateOrThis
Repository:
rCTE Clang Tools Extra
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice, I'd been wondering about that...
Comment at: clangd/index/SymbolCollector.cpp:36
+ return *T;
+return ND;
+ }
uber-nit: these three
ilya-biryukov created this revision.
ilya-biryukov added reviewers: sammccall, hokein.
Herald added subscribers: MaskRay, ioeric, jkorous-apple, klimek.
Previsouly, class completions items from the index were missing
template parameters in both the snippet and the label.
Repository:
rCTE
