[PATCH] D45595: [libcxx] [test] Fix nodiscard warnings.

2018-04-12 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT closed this revision. STL_MSFT added a comment. Committed with a follow-up to use the requested macro. https://reviews.llvm.org/D45595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D45595: [libcxx] [test] Fix nodiscard warnings.

2018-04-12 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. There's a macro for this in test_macros.h to make it easier to search for. please use that https://reviews.llvm.org/D45595 ___ cfe-commits maili

[PATCH] D45595: [libcxx] [test] Fix nodiscard warnings.

2018-04-12 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. [libcxx] [test] Fix nodiscard warnings. MSVC's STL has marked to_bytes/from_bytes as nodiscard. https://reviews.llvm.org/D45595 Files: test/std/localization/locales/locale.convenience/conversions/conversions.stri