This revision was automatically updated to reflect the committed changes.
Closed by commit rC330422: [Driver] Support for -save-stats in AddGoldPlugin.
(authored by fhahn, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45771?vs=143292&id=143299#toc
Repository:
rC Clang
h
fhahn updated this revision to Diff 143292.
fhahn marked 2 inline comments as done.
fhahn added a comment.
Thank you very much for the review and the excellent suggestions. I simplified
getStatsFileName, added a doxygen comment and changed the arguments of
AddGoldPlugin as suggested
https://re
compnerd accepted this revision.
compnerd added a comment.
Some cleanup suggestions included, but I like the change overall.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:1250
+ // Setup statistics file output.
+ if (const Arg *A = Args.getLastArg(options::OPT_save_stats_E
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM with comment nit
Comment at: lib/Driver/ToolChains/CommonArgs.h:107
llvm::opt::OptSpecifier Group);
+SmallString<128> getStatsFileN
fhahn created this revision.
fhahn added reviewers: tejohnson, mehdi_amini, compnerd.
Herald added a subscriber: emaste.
fhahn added a dependency: D45531: [LTO] Add stats-file option to LTO/Config.h..
This patch updates AddGoldPlugin to pass stats-file to the Gold plugin,
if -save-stats is passed.
