This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL330835: [clangd] Add "str()" method to SymbolID.
(authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://revie
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clangd/index/Index.h:72
+ // Returns a 40-bytes hex encoded string.
+ std::string str() const;
ioeric wrote:
> I think Sam wants to reduce the size to 20 bytes. Maybe just drop
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm with a nit
Comment at: clangd/index/Index.h:72
+ // Returns a 40-bytes hex encoded string.
+ std::string str() const;
I think Sam wants to reduce th
hokein created this revision.
hokein added a reviewer: ioeric.
Herald added subscribers: jkorous, MaskRay, ilya-biryukov, klimek.
This is a convenient function when we try to get std::string of
SymbolID.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46065
Files:
clangd/globa
