This revision was automatically updated to reflect the committed changes.
Closed by commit rC332338: [ASTImporter] Extend lookup logic in class templates
(authored by a.sidorin, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46353?vs=146765&id=146780#toc
Repository:
rC Cl
martong added a comment.
Hi Aleksei,
Added the FIXME, can you help me with committing this?
Repository:
rC Clang
https://reviews.llvm.org/D46353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
martong updated this revision to Diff 146765.
martong added a comment.
- Add FIXME
Repository:
rC Clang
https://reviews.llvm.org/D46353
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D46353#1086456, @martong wrote:
> > should we add this new declaration to the redeclaration chain like we do it
> > for RecordDecls?
>
> I think, on a long te
martong added a comment.
> should we add this new declaration to the redeclaration chain like we do it
> for RecordDecls?
I think, on a long term we should. Otherwise we could loose e.g. C++11
attributes which are attached to the forward declaration only.
However, I'd do that as a separate comm
a.sidorin added a comment.
Hello Gabor,
Thank you for the patch. It looks mostly good, but I have a question: should we
add this new declaration to the redeclaration chain like we do it for
RecordDecls?
Repository:
rC Clang
https://reviews.llvm.org/D46353
___
martong added a comment.
> During import of a class template, lookup may find a forward declaration and
> structural match falsely reports equivalency in between a fwd decl and a
> definition.
This can happen when the class to be imported does not have any data members.
Structural equivalency
martong created this revision.
martong added reviewers: a.sidorin, xazax.hun, szepet.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs.
During import of a class template, lookup may find a forward declaration and
structural match falsely reports equivalency in between a fwd decl and a
def
