rjmccall added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:1893
+
+IsCtor = isa(TargetDecl);
}
AntonBikineev wrote:
> rjmccall wrote:
> > I feel like you should just use `TargetDecl &&
> > isa(TargetDecl)` below; it's more obvious.
> >
> > Is the
rjmccall accepted this revision.
rjmccall added a comment.
LGTM.
Comment at: lib/CodeGen/CGCall.cpp:2049
+// from the constructor’s this pointer, the value of the object or
+// subobject thus obtained is unspecified.
+unsigned ThisIRArg, NumIRArgs;
-
AntonBikineev added a comment.
@rsmith do you have any comments or suggestions?
https://reviews.llvm.org/D46441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
I wonder if we should have a `-fno-strict-something` flag for this. I suppose
there's no more effective way to find out than to try this and see what happens.
Comment at: li
AntonBikineev added a comment.
@rsmith, thanks. Le'ts see if there is a need for the command-line option down
the road.
Repository:
rL LLVM
https://reviews.llvm.org/D46441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
