[PATCH] D46593: Allow copy elision in path concatenation

2018-05-09 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc added a comment. In https://reviews.llvm.org/D46593#1093758, @jwakely wrote: > @chandlerc thanks for catching this. > > As the original author I agree to contribute this patch to libc++ under the > terms of the MIT and the University of Illinois licences, and under the terms > of "Apa

[PATCH] D46593: Allow copy elision in path concatenation

2018-05-09 Thread Jonathan Wakely via Phabricator via cfe-commits
jwakely added a comment. @chandlerc thanks for catching this. As the original author I agree to contribute this patch to libc++ under the terms of the MIT and the University of Illinois licences, and under the terms of "Apache 2 with LLVM exception" if necessary in future. This permission appl

[PATCH] D46593: Allow copy elision in path concatenation

2018-05-09 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. Ping @jwakely Repository: rCXX libc++ https://reviews.llvm.org/D46593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46593: Allow copy elision in path concatenation

2018-05-09 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc added a comment. Sorry folks, but you can't just take patches to libstdc++ and apply them to libc++. These libraries have different licenses, and so the author of the patch (Jonathan Wakely in this case) need's to *explicitly* contribute that patch to libc++ under libc++'s license. (

[PATCH] D46593: Allow copy elision in path concatenation

2018-05-09 Thread Dávid Bolvanský via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCXX331910: Allow copy elision in path concatenation (authored by xbolva00, committed by ). Repository: rCXX libc++ https://reviews.llvm.org/D46593 Files: include/experimental/filesystem Index: incl

[PATCH] D46593: Allow copy elision in path concatenation

2018-05-08 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. In https://reviews.llvm.org/D46593#1091732, @smeenai wrote: > Generating the patch from libc++ is fine (and this patch looks like it has > sane paths). Thank you https://reviews.llvm.org/D46593 ___ cfe-commits mailing l

[PATCH] D46593: Allow copy elision in path concatenation

2018-05-08 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Generating the patch from libc++ is fine (and this patch looks like it has sane paths). https://reviews.llvm.org/D46593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D46593: Allow copy elision in path concatenation

2018-05-08 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 updated this revision to Diff 145745. xbolva00 added a comment. Can anybody give me advice from where to generate patch? I do it from libcxx. https://reviews.llvm.org/D46593 Files: include/experimental/filesystem Index: include/experimental/filesystem ==

[PATCH] D46593: Allow copy elision in path concatenation

2018-05-08 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 updated this revision to Diff 145742. Herald added a subscriber: christof. https://reviews.llvm.org/D46593 Files: libcxx/trunk/include/experimental/filesystem Index: libcxx/trunk/include/experimental/filesystem === --- l

[PATCH] D46593: Allow copy elision in path concatenation

2018-05-08 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 updated this revision to Diff 145740. Herald added a subscriber: cfe-commits. Repository: rCXX libc++ https://reviews.llvm.org/D46593 Files: include/experimental/filesystem Index: include/experimental/filesystem === -