This revision was automatically updated to reflect the committed changes.
Closed by commit rC332021: Reland '[clang] Adding CharacteristicKind to
PPCallbacks::InclusionDirective' (authored by juliehockett, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D46614
Files:
include/c
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
https://reviews.llvm.org/D46614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
juliehockett updated this revision to Diff 146175.
https://reviews.llvm.org/D46614
Files:
include/clang/Lex/PPCallbacks.h
include/clang/Lex/PreprocessingRecord.h
lib/CodeGen/MacroPPCallbacks.cpp
lib/CodeGen/MacroPPCallbacks.h
lib/Frontend/DependencyFile.cpp
lib/Frontend/DependencyGrap
aaron.ballman added inline comments.
Comment at: unittests/Lex/PPCallbacksTest.cpp:155-160
+std::unique_ptr PP = llvm::make_unique(
+std::make_shared(), Diags, LangOpts, SourceMgr,
+PCMCache, HeaderInfo, ModLoader,
+/*IILookup =*/nullptr,
+/*Ow
juliehockett updated this revision to Diff 146158.
juliehockett marked 3 inline comments as done.
juliehockett added a comment.
Removing unused function
https://reviews.llvm.org/D46614
Files:
include/clang/Lex/PPCallbacks.h
include/clang/Lex/PreprocessingRecord.h
lib/CodeGen/MacroPPCallba
aaron.ballman added inline comments.
Comment at: unittests/Lex/PPCallbacksTest.cpp:140
+ std::unique_ptr getPreprocessor(const char *SourceText,
+const char *HeaderPath,
This function appears to be unused?
juliehockett updated this revision to Diff 146032.
juliehockett added a comment.
Reverted because of memory leak in PPCallbacksTest, this fixes it.
https://reviews.llvm.org/D46614
Files:
include/clang/Lex/PPCallbacks.h
include/clang/Lex/PreprocessingRecord.h
lib/CodeGen/MacroPPCallbacks.c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331904: [clang] Adding CharacteristicKind to
PPCallbacks::InclusionDirective (authored by juliehockett, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
juliehockett added a comment.
This will break things in clang-tools-extra without
https://reviews.llvm.org/D46615, so I'm going to hold off landing this until
that goes through
https://reviews.llvm.org/D46614
___
cfe-commits mailing list
cfe-commi
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
https://reviews.llvm.org/D46614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
juliehockett updated this revision to Diff 145941.
juliehockett marked 3 inline comments as done.
juliehockett added a comment.
Fixing formatting and tests.
https://reviews.llvm.org/D46614
Files:
include/clang/Lex/PPCallbacks.h
include/clang/Lex/PreprocessingRecord.h
lib/CodeGen/MacroPPCa
aaron.ballman added inline comments.
Comment at: unittests/Lex/PPCallbacksTest.cpp:142-143
// the InclusionDirective callback.
- CharSourceRange InclusionDirectiveFilenameRange(const char* SourceText,
- const char* HeaderPath, bool SystemHeader) {
+ InclusionDirectiveC
juliehockett updated this revision to Diff 145934.
juliehockett added a comment.
Adding test
https://reviews.llvm.org/D46614
Files:
include/clang/Lex/PPCallbacks.h
include/clang/Lex/PreprocessingRecord.h
lib/CodeGen/MacroPPCallbacks.cpp
lib/CodeGen/MacroPPCallbacks.h
lib/Frontend/Depe
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a small nit.
Comment at: unittests/Lex/PPCallbacksTest.cpp:53
+this->Imported = Imported;
+this->FileType = FileType;
}
Ca
juliehockett created this revision.
juliehockett added a reviewer: aaron.ballman.
juliehockett added a project: clang.
Herald added subscribers: kbarton, nemanjai.
Adding a SrcMgr::CharacteristicKind parameter to the InclusionDirective in
PPCallbacks, and updating calls to that function. This wil
15 matches
Mail list logo
