lahwaacz added a comment.
This revision does not do the right thing because it makes it impossible to use
the std::min and std::max functions in __host__ __device__ functions under
C++14: https://bugs.llvm.org/show_bug.cgi?id=37753
Repository:
rC Clang
https://reviews.llvm.org/D46993
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rC332619: [CUDA] Make std::min/max work when compiling in
C++14 mode with a C++11 stdlib. (authored by jlebar, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46993?vs=147224&id=147330#
jlebar added a comment.
Thank you for the review!
https://reviews.llvm.org/D46993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D46993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
jlebar created this revision.
jlebar added a reviewer: rsmith.
Herald added a subscriber: sanjoy.
https://reviews.llvm.org/D46993
Files:
clang/lib/Headers/cuda_wrappers/algorithm
Index: clang/lib/Headers/cuda_wrappers/algorithm
=