This revision was automatically updated to reflect the committed changes.
Closed by commit rL333532: Reland "Move #include manipulation code to new
lib/Tooling/Inclusions." (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47068?vs=149091&id=149092#toc
Rep
ioeric updated this revision to Diff 149091.
ioeric added a comment.
- Fix module build.
Repository:
rC Clang
https://reviews.llvm.org/D47068
Files:
include/clang/Format/Format.h
include/clang/Tooling/Core/HeaderIncludes.h
include/clang/Tooling/Core/IncludeStyle.h
include/clang/Tooli
ioeric reopened this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
This was reverted in r332751 due to build bot failure with module config. I
don't see how this failed as the directory setup is very similar to
Tooling/Core/. Will investigate further next wee
This revision was automatically updated to reflect the committed changes.
ioeric marked an inline comment as done.
Closed by commit rL332720: Move #include manipulation code to new
lib/Tooling/Inclusions. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior
ioeric marked an inline comment as done.
ioeric added inline comments.
Comment at: include/clang/Format/Format.h:20
#include "clang/Tooling/Core/Replacement.h"
+#include "clang/Tooling/Inclusions/IncludeStyle.h"
#include "llvm/ADT/ArrayRef.h"
ilya-biryukov wrot
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM with a minor naming suggestion.
Comment at: include/clang/Format/Format.h:20
#include "clang/Tooling/Core/Replacement.h"
+#include "clang/Tooling/Inclusio
ioeric created this revision.
ioeric added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, mgorny, klimek.
clangToolingCore is linked into almost everything (incl. clang), but
not few tools need #include manipulation at this point. So pull this into a
separate library in Tooling.
