[PATCH] D47109: LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()"

Quuxplusone added a comment. > We also need to mark this off in the status. I can do that in D58879 > or create a separate patch. Good catch! Either is fine with me but I bet a separate patch would be more appropriate. Repository: rCXX libc++ CHANGES

[PATCH] D47109: LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()"

zoecarver added a comment. Herald added subscribers: libcxx-commits, ldionne. We also need to mark this off in the status. I can do that in D58879 or create a separate patch. Repository: rCXX libc++ CHANGES SINCE LAST ACTION

[PATCH] D47109: LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()"

EricWF closed this revision. EricWF added a comment. Committed as r84. Repository: rCXX libc++ https://reviews.llvm.org/D47109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47109: LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()"

Quuxplusone added a comment. > Sounds good to me. I don't have commit privs so could you land it for me? @EricWF ping! Repository: rCXX libc++ https://reviews.llvm.org/D47109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47109: LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()"

Quuxplusone added a comment. In https://reviews.llvm.org/D47109#1105680, @EricWF wrote: > This LGTM. Let's land it and see if anybody complains. Sounds good to me. I don't have commit privs so could you land it for me? (Besides, I'm happy for you to get the blame if it *does* break someone's

[PATCH] D47109: LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()"

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. This LGTM. Let's land it and see if anybody complains. Repository: rCXX libc++ https://reviews.llvm.org/D47109 ___ cfe-commits mailing list

[PATCH] D47109: LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()"

Quuxplusone updated this revision to Diff 147676. Quuxplusone added a comment. Herald added a subscriber: christof. Fix two more tests hiding in test/libcxx/, and give -U999 context. Repository: rCXX libc++ https://reviews.llvm.org/D47109 Files: include/experimental/memory_resource

[PATCH] D47109: LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()"

Quuxplusone created this revision. Quuxplusone added a reviewer: EricWF. Herald added a subscriber: cfe-commits. In the TS, `uses_allocator` construction for `pair` tried to use an allocator type of `memory_resource*`, which is incorrect because `memory_resource*` is not an allocator type. LWG