[PATCH] D47340: [ClangDiagnostics] Silence warning about fallthrough after PrintFatalError

This revision was automatically updated to reflect the committed changes. Closed by commit rL40: [ClangDiagnostics] Silence warning about fallthrough after PrintFatalError (authored by xbolva00, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D47340: [ClangDiagnostics] Silence warning about fallthrough after PrintFatalError

This revision was automatically updated to reflect the committed changes. Closed by commit rC40: [ClangDiagnostics] Silence warning about fallthrough after PrintFatalError (authored by xbolva00, committed by ). Repository: rL LLVM https://reviews.llvm.org/D47340 Files: utils/TableGen/Cl

[PATCH] D47340: [ClangDiagnostics] Silence warning about fallthrough after PrintFatalError

rtrieu accepted this revision. rtrieu added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D47340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D47340: [ClangDiagnostics] Silence warning about fallthrough after PrintFatalError

xbolva00 added a comment. Ok? https://reviews.llvm.org/D47340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47340: [ClangDiagnostics] Silence warning about fallthrough after PrintFatalError

xbolva00 updated this revision to Diff 148523. xbolva00 added a comment. Add correct NORETURN attribute https://reviews.llvm.org/D47340 Files: utils/TableGen/ClangDiagnosticsEmitter.cpp Index: utils/TableGen/ClangDiagnosticsEmitter.cpp ===

[PATCH] D47340: [ClangDiagnostics] Silence warning about fallthrough after PrintFatalError

rtrieu added a comment. Instead of adding a break, you should add a noreturn attribute to the PrintFatalError function. LLVM has the macro LLVM_ATTRIBUTE_NORETURN to do this. You can confirm that PrintFatalError is a noreturn function by seeing that it unconditionally calls llvm::PrintFatalEr

[PATCH] D47340: [ClangDiagnostics] Silence warning about fallthrough after PrintFatalError

xbolva00 created this revision. Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov. ClangDiagnosticsEmitter.cpp:1047:57: warning: this statement may fall through [-Wimplicit-fallthrough=] Builder.PrintFatalError("Unknown modifier type: " + Modifier);