This revision was automatically updated to reflect the committed changes.
Closed by commit rC334065: [Analyzer] Fix Z3ConstraintManager crash (PR37646)
(authored by vlad.tsyrklevich, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47617?vs=149796&id=150074#toc
Repository:
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D47617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
vlad.tsyrklevich updated this revision to Diff 149796.
vlad.tsyrklevich added a comment.
- Merge test with apsint.c and move to z3/apsint.c
Repository:
rC Clang
https://reviews.llvm.org/D47617
Files:
lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp
test/Analysis/apsint.c
test/Analysis/z
vlad.tsyrklevich added a comment.
In https://reviews.llvm.org/D47617#1119268, @NoQ wrote:
> Also does this test need to be z3-specific? We would also not like to crash
> here without z3.
I originally did that so I could specify enabling and testing the z3 backend;
however, looking at the test
ddcc added a comment.
In https://reviews.llvm.org/D47617#1119257, @george.karpenkov wrote:
> LGTM with a nit on a test name.
Same.
In https://reviews.llvm.org/D47617#1119268, @NoQ wrote:
> Also does this test need to be z3-specific? We would also not like to crash
> here without z3.
I had
NoQ added a comment.
We might as well make a directory for z3-specific tests. Eg.,
`z3/bool-bit-width.c`.
Also does this test need to be z3-specific? We would also not like to crash
here without z3.
Repository:
rC Clang
https://reviews.llvm.org/D47617
___
george.karpenkov added a comment.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D47617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
LGTM with a nit on a test name.
Comment at: test/Analysis/pr37646.c:1
+// REQUIRES: z3
+// RUN: %clang_analyze_cc1 -triple x86_64-apple-darwin9
