[PATCH] D47707: [clangd] Downrank symbols with reserved names (score *= 0.1)

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE334274: [clangd] Downrank symbols with reserved names (score *= 0.1) (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D47707?vs=150115=150469#toc Repository:

[PATCH] D47707: [clangd] Downrank symbols with reserved names (score *= 0.1)

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, sorry for the delay Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47707 ___ cfe-commits mailing list

[PATCH] D47707: [clangd] Downrank symbols with reserved names (score *= 0.1)

sammccall added a comment. @ilya-biryukov Ping, anything left for me to do here? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47707: [clangd] Downrank symbols with reserved names (score *= 0.1)

sammccall updated this revision to Diff 150115. sammccall added a comment. Add test that _f isn't a reserved name. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47707 Files: clangd/Quality.cpp clangd/Quality.h unittests/clangd/QualityTests.cpp Index:

[PATCH] D47707: [clangd] Downrank symbols with reserved names (score *= 0.1)

ilya-biryukov added a comment. After chatting offline: a FIXME mentioning some special cases seems enough here, we do improve the results in most cases (i.e. for queries that don't start with an underscore). Another NIT: Maybe we could add unittests for names that start with underscore, but

[PATCH] D47707: [clangd] Downrank symbols with reserved names (score *= 0.1)

sammccall updated this revision to Diff 149735. sammccall added a comment. FIXMEs pertaining to queries beginning with _, and standard _Names Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47707 Files: clangd/Quality.cpp clangd/Quality.h unittests/clangd/QualityTests.cpp

[PATCH] D47707: [clangd] Downrank symbols with reserved names (score *= 0.1)

sammccall added a comment. In https://reviews.llvm.org/D47707#1120734, @ilya-biryukov wrote: > Is there a way to only downrank them if the query does not start with `_`? > That would cover the cases when I **do** want the symbols starting with > underscore. This is hard for a few reasons: -

[PATCH] D47707: [clangd] Downrank symbols with reserved names (score *= 0.1)

ilya-biryukov added a comment. Is there a way to only downrank them if the query does not start with `_`? That would cover the cases when I **do** want the symbols starting with underscore. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47707

[PATCH] D47707: [clangd] Downrank symbols with reserved names (score *= 0.1)

sammccall updated this revision to Diff 149732. sammccall added a comment. Forgot to add to debug string. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47707 Files: clangd/Quality.cpp clangd/Quality.h unittests/clangd/QualityTests.cpp Index:

[PATCH] D47707: [clangd] Downrank symbols with reserved names (score *= 0.1)

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47707 Files: clangd/Quality.cpp clangd/Quality.h