[PATCH] D47787: [clangd] Adjust symbol score based on crude symbol type.

2018-06-06 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rL334074: Adjust symbol score based on crude symbol type. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D47787: [clangd] Adjust symbol score based on crude symbol type.

2018-06-05 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Comment at: clangd/Quality.cpp:33 +static SymbolQualitySignals::SymbolCategory categorize(const NamedDecl &ND) { + class Switch Have you considered `

[PATCH] D47787: [clangd] Adjust symbol score based on crude symbol type.

2018-06-05 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: ioeric. Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov. Numbers are guesses to be adjusted later. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47787 Files: clangd/Quality.cpp clangd/Quali