This revision was automatically updated to reflect the committed changes.
Closed by commit rC334108: [CUDA] Replace 'nv_weak' attributes in
CUDA headers with 'weak'. (authored by tra, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47804?vs=150055&id=150166#toc
Repository:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM as well, for what little it's worth. :-)
https://reviews.llvm.org/D47804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Hahnfeld accepted this revision.
Hahnfeld added a subscriber: fwyzard.
Hahnfeld added a comment.
Works for me, I'll abandon https://reviews.llvm.org/D47201 if you prefer this.
https://reviews.llvm.org/D47804
___
cfe-commits mailing list
cfe-commits@
tra added a comment.
I'll wait to see if that fixes @Hahnfeld's problem.
AFAICT, nv_weak is not used for anything interesting other than the device-side
runtime stubs that return errors (apparently, until they are linked with the
proper device runtime which would have strong version of the symb
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
What could possibly go wrong.
https://reviews.llvm.org/D47804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
tra created this revision.
tra added reviewers: Hahnfeld, aaron.ballman, jlebar.
Herald added subscribers: bixia, sanjoy.
An alternative to implementing nv_weak attribute
(https://reviews.llvm.org/D47201).
The patch should make runtime sub functions to have .weak attribute in PTX and
that shoul
