[PATCH] D47847: [clangd] Simplify matches in FindSymbols tests

2018-06-26 Thread Marc-Andre Laperle via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL335624: [clangd] Simplify matches in FindSymbols tests (authored by malaperle, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47847 Files: cla

[PATCH] D47847: [clangd] Simplify matches in FindSymbols tests

2018-06-26 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle accepted this revision. malaperle added a comment. This revision is now accepted and ready to land. Self-approving because this is pretty inconsequential. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47847 ___ cfe-commit

[PATCH] D47847: [clangd] Simplify matches in FindSymbols tests

2018-06-22 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle updated this revision to Diff 152536. malaperle added a comment. Rebased. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47847 Files: unittests/clangd/FindSymbolsTests.cpp Index: unittests/clangd/FindSymbolsTests.cpp

[PATCH] D47847: [clangd] Simplify matches in FindSymbols tests

2018-06-06 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle created this revision. Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov. Instead of checking symbol name and container (scope) separately, check the qualified name instead. This is much shorter and similar to how it is done in the SymbolCollector tests. Sig