[PATCH] D47886: Move VersionTuple from clang/Basic to llvm/Support, clang part

2018-06-11 Thread Pavel Labath via Phabricator via cfe-commits
labath closed this revision. labath added a comment. Committed as a part of https://reviews.llvm.org/D47887 via monorepo. Repository: rC Clang https://reviews.llvm.org/D47886 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47886: Move VersionTuple from clang/Basic to llvm/Support, clang part

2018-06-08 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM. Looks like LLDB has some uses of VersionTuple, you should fix those to #include the LLVM version before removing the header here. (Or, better yet, do it all atomically

[PATCH] D47886: Move VersionTuple from clang/Basic to llvm/Support, clang part

2018-06-07 Thread Pavel Labath via Phabricator via cfe-commits
labath created this revision. labath added reviewers: erik.pilkington, zturner. Herald added a subscriber: mgorny. This kind of functionality is useful to other project apart from clang. LLDB works with version numbers a lot, but it does not have a convenient abstraction for this. Moving this