[PATCH] D47964: Modified protobuf and converter to add new signature, remove conditionals.

2018-06-11 Thread Matt Morehouse via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL334421: [clang-fuzzer] Modified protobuf and converter to add new signature, removeā€¦ (authored by morehouse, committed by ). Repository: rL LLVM https://reviews.llvm.org/D47964 Files:

[PATCH] D47964: Modified protobuf and converter to add new signature, remove conditionals.

2018-06-11 Thread Emmett Neyman via Phabricator via cfe-commits
emmettneyman updated this revision to Diff 150783. emmettneyman added a comment. - removed include statement meant for testing Repository: rC Clang https://reviews.llvm.org/D47964 Files: tools/clang-fuzzer/cxx_loop_proto.proto tools/clang-fuzzer/proto-to-cxx/loop_proto_to_cxx.cpp

[PATCH] D47964: Modified protobuf and converter to add new signature, remove conditionals.

2018-06-11 Thread Emmett Neyman via Phabricator via cfe-commits
emmettneyman added a comment. @kcc suggested removing conditionals for now and adding them back later. include statement was for testing; I'll remove it and resubmit. Repository: rC Clang https://reviews.llvm.org/D47964 ___ cfe-commits mailing

[PATCH] D47964: Modified protobuf and converter to add new signature, remove conditionals.

2018-06-11 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse added inline comments. Comment at: tools/clang-fuzzer/cxx_loop_proto.proto:67 -AssignmentStatement assignment = 1; -IfElse ifelse = 2; - } Do you really want to get rid of if-else? Comment at:

[PATCH] D47964: Modified protobuf and converter to add new signature, remove conditionals.

2018-06-08 Thread Emmett Neyman via Phabricator via cfe-commits
emmettneyman created this revision. emmettneyman added reviewers: kcc, morehouse, vitalybuka. Herald added a subscriber: cfe-commits. Cahnged the function signature and removed conditionals from loop body. Repository: rC Clang https://reviews.llvm.org/D47964 Files: