This revision was automatically updated to reflect the committed changes.
Closed by commit rC334741: [X86] Lowering Mask Scalar intrinsics to native IR
(Clang part) (authored by tkrupa, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47979?vs=150617&id=151381#toc
Repository:
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D47979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
tkrupa added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:9926
+Value *Div = Builder.CreateFDiv(A, B);
+llvm::VectorType *MaskTy = llvm::VectorType::get(Builder.getInt1Ty(),
+
cast(Mask->getType())->getBitWidth());
c
craig.topper added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:9926
+Value *Div = Builder.CreateFDiv(A, B);
+llvm::VectorType *MaskTy = llvm::VectorType::get(Builder.getInt1Ty(),
+
cast(Mask->getType())->getBitWidth());
tkrupa created this revision.
tkrupa added reviewers: craig.topper, RKSimon, spatel, sroland.
Herald added a subscriber: cfe-commits.
I did the div differently because it got split to three basic blocks with
a branch condition (due to div being an expensive operation)
and couldn't be combined back
