[PATCH] D48159: [clangd] Implement hover for "auto" and "decltype"

This revision was automatically updated to reflect the committed changes. Closed by commit rL336119: [clangd] Implement hover for auto and decltype (authored by malaperle, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D48159 Files:

[PATCH] D48159: [clangd] Implement hover for "auto" and "decltype"

malaperle added inline comments. Comment at: clangd/XRefs.cpp:559 + //- auto& i = 1; + bool VisitDeclaratorDecl(DeclaratorDecl *D) { +if (!D->getTypeSourceInfo() || klimek wrote: > klimek wrote: > > malaperle wrote: > > > klimek wrote: > > > > sammccall

[PATCH] D48159: [clangd] Implement hover for "auto" and "decltype"

malaperle updated this revision to Diff 153737. malaperle added a comment. Tweak comment with FIXME. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48159 Files: clangd/XRefs.cpp unittests/clangd/TestTU.cpp unittests/clangd/TestTU.h unittests/clangd/XRefsTests.cpp

[PATCH] D48159: [clangd] Implement hover for "auto" and "decltype"

klimek accepted this revision. klimek added inline comments. Comment at: clangd/XRefs.cpp:559 + //- auto& i = 1; + bool VisitDeclaratorDecl(DeclaratorDecl *D) { +if (!D->getTypeSourceInfo() || klimek wrote: > malaperle wrote: > > klimek wrote: > > >

[PATCH] D48159: [clangd] Implement hover for "auto" and "decltype"

malaperle updated this revision to Diff 153612. malaperle added a comment. Add comment about AutoTypeLoc work-around. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48159 Files: clangd/XRefs.cpp unittests/clangd/TestTU.cpp unittests/clangd/TestTU.h

[PATCH] D48159: [clangd] Implement hover for "auto" and "decltype"

klimek added a reviewer: rsmith. klimek added inline comments. Comment at: clangd/XRefs.cpp:559 + //- auto& i = 1; + bool VisitDeclaratorDecl(DeclaratorDecl *D) { +if (!D->getTypeSourceInfo() || malaperle wrote: > klimek wrote: > > sammccall wrote: > > >

[PATCH] D48159: [clangd] Implement hover for "auto" and "decltype"

malaperle added inline comments. Comment at: clangd/XRefs.cpp:559 + //- auto& i = 1; + bool VisitDeclaratorDecl(DeclaratorDecl *D) { +if (!D->getTypeSourceInfo() || klimek wrote: > sammccall wrote: > > malaperle wrote: > > > sammccall wrote: > > > > out of

[PATCH] D48159: [clangd] Implement hover for "auto" and "decltype"

klimek added inline comments. Comment at: clangd/XRefs.cpp:559 + //- auto& i = 1; + bool VisitDeclaratorDecl(DeclaratorDecl *D) { +if (!D->getTypeSourceInfo() || sammccall wrote: > malaperle wrote: > > sammccall wrote: > > > out of curiosity, why not

[PATCH] D48159: [clangd] Implement hover for "auto" and "decltype"

sammccall accepted this revision. sammccall added a subscriber: klimek. sammccall added a comment. All sounds good to me. Comment at: clangd/XRefs.cpp:559 + //- auto& i = 1; + bool VisitDeclaratorDecl(DeclaratorDecl *D) { +if (!D->getTypeSourceInfo() ||

[PATCH] D48159: [clangd] Implement hover for "auto" and "decltype"

malaperle updated this revision to Diff 153153. malaperle added a comment. Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48159 Files: clangd/XRefs.cpp unittests/clangd/TestTU.cpp unittests/clangd/TestTU.h unittests/clangd/XRefsTests.cpp Index:

[PATCH] D48159: [clangd] Implement hover for "auto" and "decltype"

malaperle marked 4 inline comments as done. malaperle added inline comments. Comment at: clangd/XRefs.cpp:559 + //- auto& i = 1; + bool VisitDeclaratorDecl(DeclaratorDecl *D) { +if (!D->getTypeSourceInfo() || sammccall wrote: > out of curiosity, why not

[PATCH] D48159: [clangd] Implement hover for "auto" and "decltype"

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This is so great, thank you! Comment at: clangd/XRefs.cpp:544 +/// Computes the deduced type at a given location by visiting the relevant +/// nodes. +class

[PATCH] D48159: [clangd] Implement hover for "auto" and "decltype"

malaperle updated this revision to Diff 152958. malaperle added a comment. Rebased. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48159 Files: clangd/XRefs.cpp unittests/clangd/TestTU.cpp unittests/clangd/TestTU.h unittests/clangd/XRefsTests.cpp Index:

[PATCH] D48159: [clangd] Implement hover for "auto" and "decltype"

malaperle created this revision. Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov. This allows hovering on keywords that refer to deduced types. This should cover most useful cases. Not covered: - auto template parameters: Since this can be instantiated with many