This revision was automatically updated to reflect the committed changes.
Closed by commit rC335111: [SPIR] Prevent SPIR targets from using half
conversion intrinsics (authored by SjoerdMeijer, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48188?vs=151938&id=152045#toc
Rep
SjoerdMeijer added a comment.
No problem, will commit this today.
https://reviews.llvm.org/D48188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smcgro added a comment.
That's great @SjoerdMeijer , thanks for the review. I don't have commit access
to clang so if there are no more reviews then it would be great if someone
could commit this for me, thanks.
https://reviews.llvm.org/D48188
___
smcgro updated this revision to Diff 151938.
smcgro added a comment.
Added a function parameter to one of the functions
https://reviews.llvm.org/D48188
Files:
lib/Basic/Targets/SPIR.h
test/CodeGen/spir-half-type.cpp
Index: test/CodeGen/spir-half-type.cpp
===
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
Looks OK to me.
Comment at: test/CodeGen/spir-half-type.cpp:89
+
+_Float16 fadd() {
+ _Float16 a = 1.0f16;
Nit: let one of these functions take
smcgro updated this revision to Diff 151512.
https://reviews.llvm.org/D48188
Files:
lib/Basic/Targets/SPIR.h
test/CodeGen/spir-half-type.cpp
Index: test/CodeGen/spir-half-type.cpp
===
--- /dev/null
+++ test/CodeGen/spir-half-typ
smcgro added a comment.
Thanks for the feedback @SjoerdMeijer I've updated the commit message and
responded to the comments
Comment at: lib/Basic/Targets/SPIR.h:50
UseAddrSpaceMapMangling = true;
+HasLegalHalfType = true;
// Define available target features
-
SjoerdMeijer added a comment.
I know very little about SPIR, and Initially didn't understand this:
> The SPIR target currently allows for half precision floating point types to
> use the LLVM intrinsic functions to convert to floats and doubles. This is
> illegal in SPIR as the only intrinsic a
smcgro created this revision.
smcgro added reviewers: SjoerdMeijer, rsmith.
Herald added a subscriber: cfe-commits.
The SPIR target currently allows for half precision floating point types to use
the LLVM intrinsic functions to convert to floats and doubles. This is illegal
in SPIR as the only i
