This revision was automatically updated to reflect the committed changes.
Closed by commit rL337447: [PCH+Modules] Load -fmodule-map-file content before
including PCHs (authored by bruno, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D48685
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bruno added a comment.
Herald added a subscriber: dexonsmith.
Ping!
https://reviews.llvm.org/D48685
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno created this revision.
bruno added reviewers: rsmith, benlangmuir.
Consider:
1. Generate PCH with -fmodules and -fmodule-map-file
2. Use PCH with -fmodules and the same -fmodule-map-file
If we don't load -fmodule-map-file content before including PCHs, the modules
that are dependencies
