This revision was automatically updated to reflect the committed changes.
shuaiwang marked an inline comment as done.
Closed by commit rL336737: Use ExprMutationAnalyzer in
performance-for-range-copy (authored by shuaiwang, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
shuaiwang marked an inline comment as done.
shuaiwang added inline comments.
Comment at: test/clang-tidy/performance-for-range-copy.cpp:120
+struct Point {
+ ~Point() {}
JonasToth wrote:
> I feel that `const` methods should be added as a test as well.
const
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
JonasToth added inline comments.
Comment at: test/clang-tidy/performance-for-range-copy.cpp:120
+struct Point {
+ ~Point() {}
I feel that `const` methods should be added as a test as well.
Repository:
rCTE Clang Tools Extra
shuaiwang created this revision.
Herald added a reviewer: george.karpenkov.
Herald added subscribers: cfe-commits, a.sidorin.
This gives better coverage to the check as ExprMutationAnalyzer is more
accurate comparing to isOnlyUsedAsConst.
Majority of wins come from const usage of member field,
