rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9051
def err_implied_coroutine_type_not_found : Error<
"%0 type was not found; include before defining "
"a coroutine">;
Maybe we should also remove the "%0 type was not
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9053
"a coroutine">;
+def note_coroutine_types_for_traits_here : Note<
+ "the coroutine traits class template is being instantiated using the return "
modocache wrote:
> GorN
modocache added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9053
"a coroutine">;
+def note_coroutine_types_for_traits_here : Note<
+ "the coroutine traits class template is being instantiated using the return "
GorNishanov wrote:
>
GorNishanov added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9053
"a coroutine">;
+def note_coroutine_types_for_traits_here : Note<
+ "the coroutine traits class template is being instantiated using the return "
I am wondering wha
modocache updated this revision to Diff 153956.
modocache added a comment.
Oops, apologies, I included a line I shouldn't have in the previous diff.
Repository:
rC Clang
https://reviews.llvm.org/D48863
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaCoroutine.cpp
test/Se
modocache created this revision.
modocache added reviewers: GorNishanov, EricWF.
If a user defines a coroutine_traits type that takes an incorrect
number of template parameters, or for some reason they include such
a type in their program, they receive a cryptic error message:
"too few template ar