This revision was automatically updated to reflect the committed changes.
Closed by commit rC336244: [Sema] Fix crash in getConstructorName. (authored by
ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48880?vs=154063&id=154064#toc
Repository:
rC Clang
https://
ilya-biryukov added a comment.
Thanks for taking a look!
Repository:
rC Clang
https://reviews.llvm.org/D48880
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov updated this revision to Diff 154063.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Better recovery for invalid decls that do have an injected class name
- Move the test to SemaCXX
Repository:
rC Clang
https://reviews.llvm.org/D48880
Files:
rsmith added a comment.
Looks fine, but please put the test case somewhere more appropriate (under
SemaCXX, for instance).
Comment at: lib/Sema/SemaExprCXX.cpp:117
}
assert(InjectedClassName && "couldn't find injected class name");
We would be able to
ilya-biryukov created this revision.
ilya-biryukov added reviewers: bkramer, rsmith.
Can happen when getConstructorName is called on invalid decls,
specifically the ones that do not have the injected class name.
Repository:
rC Clang
https://reviews.llvm.org/D48880
Files:
lib/Sema/SemaExprC
