Eugene.Zelenko added a comment.
You could use //Differential revision: // in commit description to
close review automatically.
https://reviews.llvm.org/D48909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
juliehockett closed this revision.
juliehockett added a comment.
Closed in https://reviews.llvm.org/rL339617.
https://reviews.llvm.org/D48909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
juliehockett marked 2 inline comments as done.
juliehockett added a comment.
In https://reviews.llvm.org/D48909#1194501, @leonardchan wrote:
> Should there be any tests associated with these changes?
There are, this is just supposed to be a NFC so the tests don't need to change.
They all pass
juliehockett marked 2 inline comments as done.
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:308
- llvm::errs() << "Invalid type for info.\n";
- exit(1);
}
leonardchan wrote:
> Probably not important or it's
leonardchan added a comment.
Should there be any tests associated with these changes?
Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:308
- llvm::errs() << "Invalid type for info.\n";
- exit(1);
}
Probably not important or it's just me being
juliehockett updated this revision to Diff 159071.
juliehockett marked 2 inline comments as done.
https://reviews.llvm.org/D48909
Files:
clang-tools-extra/clang-doc/BitcodeReader.cpp
clang-tools-extra/clang-doc/BitcodeReader.h
Index: clang-tools-extra/clang-doc/BitcodeReader.h
juliehockett updated this revision to Diff 159070.
https://reviews.llvm.org/D48909
Files:
clang-tools-extra/clang-doc/BitcodeReader.cpp
clang-tools-extra/clang-doc/BitcodeReader.h
Index: clang-tools-extra/clang-doc/BitcodeReader.h
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:13
#include "llvm/ADT/Optional.h"
#include "llvm/Support/raw_ostream.h"
Please include Support/Error.h and utility
Comment at:
juliehockett created this revision.
juliehockett added reviewers: ioeric, lebedev.ri.
juliehockett added a project: clang-tools-extra.
Replace booleans with the more descriptive llvm::Error or llvm::Expected
https://reviews.llvm.org/D48909
Files:
clang-tools-extra/clang-doc/BitcodeReader.cpp
