This revision was automatically updated to reflect the committed changes.
Closed by commit rC336523: [ASTImporter] import FunctionDecl end locations
(authored by r.stahl, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48941?vs=154215&id=154549#toc
Repository:
rC Clang
ht
a_sidorin accepted this revision.
a_sidorin added a comment.
LGTM too. Thank you!
Repository:
rC Clang
https://reviews.llvm.org/D48941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D48941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
r.stahl updated this revision to Diff 154215.
r.stahl marked 2 inline comments as done.
r.stahl added a comment.
Alright, but then I would suggest to pass an invalid loc to the constructors
instead to make it more explicit and save a map lookup in the import function.
Repository:
rC Clang
ht
a_sidorin added a comment.
Hello Rafael.
This change is good, just some cleanup is needed.
Comment at: lib/AST/ASTImporter.cpp:2559
D->isImplicit());
+ToFunction->setRangeEnd(Importer.Import(D->getLocEnd()));
} else if (auto *F
martong added inline comments.
Comment at: lib/AST/ASTImporter.cpp:2559
D->isImplicit());
+ToFunction->setRangeEnd(Importer.Import(D->getLocEnd()));
} else if (auto *FromConversion = dyn_cast(D)) {
Why don't we n
r.stahl added a comment.
In https://reviews.llvm.org/D47698#1141871, @r.stahl wrote:
> improved code quality; added nested macro test. it "works", but is disabled
> because it revealed another bug: the function end location is not imported.
> will send a patch
Related to this.
Repository:
r.stahl created this revision.
r.stahl added reviewers: martong, a.sidorin, balazske, xazax.hun.
Herald added subscribers: cfe-commits, rnkovacs.
On constructors that do not take the end source location, it was not imported.
Fixes test from https://reviews.llvm.org/D47698 /
https://reviews.llvm.
