This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE336540: [clangd] Do not write comments into Preamble PCH
(authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48943?vs=154569&id=154572#toc
Repository:
rCTE Cl
ilya-biryukov updated this revision to Diff 154569.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Fix a comment
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48943
Files:
clangd/ClangdUnit.cpp
clangd/CodeCompletionStrings.cpp
Index: cla
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Very nice!
Comment at: clangd/ClangdUnit.cpp:327
CI.getFrontendOpts().SkipFunctionBodies = true;
+ // We don't want to write comments into PCH. They are racy and sl
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: jkorous, MaskRay, ioeric.
To avoid wasting time deserializing them on code completion and
further reparses.
We do not use the comments anyway, because we cannot rely on the file
contents stay
