This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE336553: [clangd] Support indexing MACROs. (authored by
ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49028?vs=154559&id=154615#toc
Repository:
rCTE Clang Tools Extra
h
ioeric added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:360
+
+ llvm::SmallString<128> USR;
+ if (index::generateUSRForMacro(Name.getName(), MI.getDefinitionLoc(), SM,
sammccall wrote:
> as above, can we avoid generating the USR for every ref
ioeric updated this revision to Diff 154559.
ioeric marked 5 inline comments as done.
ioeric added a comment.
- Addressed review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49028
Files:
clangd/index/SymbolCollector.cpp
clangd/index/SymbolCollector.h
unittests
sammccall added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:309
+ llvm::SmallString<128> USR;
+ if (index::generateUSRForDecl(ND, USR))
why this change? I think this makes us run generateUSR much more often (once
per non-unique reference in
ioeric updated this revision to Diff 154414.
ioeric added a comment.
- Another minor cleanup.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49028
Files:
clangd/index/SymbolCollector.cpp
clangd/index/SymbolCollector.h
unittests/clangd/SymbolCollectorTests.cpp
Index: unit
ioeric updated this revision to Diff 154413.
ioeric added a comment.
- Some cleanup.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49028
Files:
clangd/index/SymbolCollector.cpp
clangd/index/SymbolCollector.h
unittests/clangd/SymbolCollectorTests.cpp
Index: unittests/cla
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov.
This is not enabled in the global-symbol-builder or dynamic index yet.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49028
Files:
clangd/
