This revision was automatically updated to reflect the committed changes.
Closed by commit rC340140: [NEON] Define fp16 vld and vst intrinsics
conditionally (authored by kosarev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49075
Files:
include/clang/Basic/arm_neon.td
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340140: [NEON] Define fp16 vld and vst intrinsics
conditionally (authored by kosarev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
https://reviews.llvm.org/D49075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kosarev added a comment.
Ping.
https://reviews.llvm.org/D49075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kosarev updated this revision to Diff 157960.
kosarev added a comment.
Test that the affected intrinsics are not defined in no-fp16 mode.
https://reviews.llvm.org/D49075
Files:
include/clang/Basic/arm_neon.td
test/CodeGen/arm-neon-vld.c
test/CodeGen/arm-neon-vst.c
SjoerdMeijer added a comment.
Now that they are conditionally defined, do we need negative tests (in
test/Sema/arm-no-fp16.c?) to check that they are not available when fp16 is not
enabled?
https://reviews.llvm.org/D49075
___
cfe-commits mailing
kosarev added a comment.
Ping.
https://reviews.llvm.org/D49075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kosarev added a comment.
Ping.
https://reviews.llvm.org/D49075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kosarev created this revision.
kosarev added reviewers: SjoerdMeijer, jgreenhalgh, rengolin.
kosarev added a project: clang.
Herald added a reviewer: javed.absar.
This patch fixes definitions of vld and vst NEON intrinsics so that we only
define them if half-precision arithmetic is supported on
