pcc added a subscriber: cfe-commits.
pcc added inline comments.
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:3215
// Emit the standard library with external linkage.
llvm::GlobalVariable::LinkageTypes Linkage;
if (IsStdLib)
`IsStdLib` will always be false a
thomasanderson updated this revision to Diff 156399.
thomasanderson marked 5 inline comments as done.
https://reviews.llvm.org/D49109
Files:
lib/CodeGen/ItaniumCXXABI.cpp
Index: lib/CodeGen/ItaniumCXXABI.cpp
===
--- lib/CodeGen/It
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D49109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pcc requested changes to this revision.
pcc added a comment.
This revision now requires changes to proceed.
Sorry, I noticed that this patch is missing a test case. Can you add one please?
https://reviews.llvm.org/D49109
___
cfe-commits mailing list
thomasanderson updated this revision to Diff 156943.
thomasanderson added a comment.
Added test. Also verified that all tests in llvm/tools/clang/test pass.
https://reviews.llvm.org/D49109
Files:
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/rtti-fundamental.cpp
Index: test/CodeGenCXX/rtt
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D49109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337788: Borrow visibility from __fundamental_type_info for
generated fundamental type… (authored by thomasanderson, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49109
Files:
lib/Co
