[PATCH] D49268: [clang-doc] Create a script to generate tests

2018-07-13 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. I have no further comments here. I assume this works as intended; if not, since it is mainly a developer-only tool, further issues could be addressed later on. Maybe wait a bit just in

[PATCH] D49268: [clang-doc] Create a script to generate tests

2018-07-13 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett added a comment. In https://reviews.llvm.org/D49268#1161268, @lebedev.ri wrote: > Did you meant to commit `clang-tools-extra/clang-doc/test_cases/` ? > I can't tell whether it is a temporary directory or not. It is, it's the code for the actual test cases that are generated (so th

[PATCH] D49268: [clang-doc] Create a script to generate tests

2018-07-13 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Nice! Some comments. Sorry about lack of the review, this kinda fell off my radar. Did you meant to commit `clang-tools-extra/clang-doc/test_cases/` ? I can't tell whether it is a temporary directory or not. Comment at: clang-tools-extra/clang-doc/g