This revision was automatically updated to reflect the committed changes.
Closed by commit rC337704: [NEON] Define half-precision vmaxnm intrinsics only
when available (authored by kosarev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49375?vs=155675=156802#toc
SjoerdMeijer added inline comments.
Comment at: include/clang/Basic/arm_neon.td:1466
def VMINH : SInst<"vmin", "ddd", "hQh">;
- def FMAXNMH : SInst<"vmaxnm", "ddd", "hQh">;
- def FMINNMH : SInst<"vminnm", "ddd", "hQh">;
+ let ArchGuard = "__ARM_ARCH >=
kosarev added a comment.
Thanks for reviewing!
Comment at: include/clang/Basic/arm_neon.td:1466
def VMINH : SInst<"vmin", "ddd", "hQh">;
- def FMAXNMH : SInst<"vmaxnm", "ddd", "hQh">;
- def FMINNMH : SInst<"vminnm", "ddd", "hQh">;
+ let ArchGuard =
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: include/clang/Basic/arm_neon.td:1466
def VMINH : SInst<"vmin", "ddd", "hQh">;
- def FMAXNMH : SInst<"vmaxnm", "ddd", "hQh">;
-
kosarev added a comment.
Ping.
https://reviews.llvm.org/D49375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kosarev created this revision.
kosarev added reviewers: SjoerdMeijer, jgreenhalgh, rengolin.
kosarev added a project: clang.
Herald added a reviewer: javed.absar.
https://reviews.llvm.org/D49375
Files:
include/clang/Basic/arm_neon.td
test/Sema/arm-no-fp16.c
Index: test/Sema/arm-no-fp16.c
