[PATCH] D49421: [CodeComplete] Fix accessibilty of protected members from base class.

This revision was automatically updated to reflect the committed changes. Closed by commit rL337453: [CodeComplete] Fix accessibilty of protected members from base class. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/

[PATCH] D49421: [CodeComplete] Fix accessibilty of protected members from base class.

This revision was automatically updated to reflect the committed changes. Closed by commit rC337453: [CodeComplete] Fix accessibilty of protected members from base class. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D49421?vs=156146&id=156257#toc Repos

[PATCH] D49421: [CodeComplete] Fix accessibilty of protected members from base class.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D49421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D49421: [CodeComplete] Fix accessibilty of protected members from base class.

ioeric added inline comments. Comment at: lib/Sema/SemaAccess.cpp:1871-1873 +// The access should be AS_none as we don't know how the member was +// accessed - `AccessedEntity::getAccess` describes what access was used to +// access an entity. aaron.b

[PATCH] D49421: [CodeComplete] Fix accessibilty of protected members from base class.

ioeric updated this revision to Diff 156146. ioeric marked an inline comment as done. ioeric added a comment. - addressed review comments. - Addressed review comments. Repository: rC Clang https://reviews.llvm.org/D49421 Files: lib/Sema/SemaAccess.cpp lib/Sema/SemaCodeComplete.cpp test

[PATCH] D49421: [CodeComplete] Fix accessibilty of protected members from base class.

aaron.ballman added inline comments. Comment at: lib/Sema/SemaAccess.cpp:1871-1873 +// The access should be AS_none as we don't know how the member was +// accessed - `AccessedEntity::getAccess` describes what access was used to +// access an entity.

[PATCH] D49421: [CodeComplete] Fix accessibilty of protected members from base class.

ioeric added a comment. Thanks for the review! Comment at: lib/Sema/SemaAccess.cpp:1871-1873 +// The access should be AS_none as we don't know how the member was +// accessed - `AccessedEntity::getAccess` describes what access was used to +// access an entity. -

[PATCH] D49421: [CodeComplete] Fix accessibilty of protected members from base class.

ioeric updated this revision to Diff 156056. ioeric marked 4 inline comments as done. ioeric added a comment. - addressed review comments. Repository: rC Clang https://reviews.llvm.org/D49421 Files: lib/Sema/SemaAccess.cpp lib/Sema/SemaCodeComplete.cpp test/Index/complete-access-checks

[PATCH] D49421: [CodeComplete] Fix accessibilty of protected members from base class.

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. Adding Richard to see if he agrees with the direction taken. Comment at: lib/Sema/SemaAccess.cpp:1871-1873 +// The access should be AS_none as we don't know how the member was +// accessed - `Accesse

[PATCH] D49421: [CodeComplete] Fix accessibilty of protected members from base class.

ioeric created this revision. ioeric added reviewers: aaron.ballman, sammccall. Herald added a subscriber: cfe-commits. Currently, protected members from base classes are marked as inaccessible when completing in derived class. This patch fixes the problem by setting the naming class correctly whe