[PATCH] D49486: [cfe][CMake] Export the clang resource directory

2018-10-30 Thread Philip Pfaffe via Phabricator via cfe-commits
philip.pfaffe abandoned this revision. philip.pfaffe added a comment. It looks like running clang will be good enough. I'm closing this for now! https://reviews.llvm.org/D49486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49486: [cfe][CMake] Export the clang resource directory

2018-10-30 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. @philip.pfaffe, did you establish whether this is still necessary or can be abandoned? https://reviews.llvm.org/D49486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49486: [cfe][CMake] Export the clang resource directory

2018-08-09 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added a comment. Please check and see if that works for you. In general I prefer to avoid adding new features that aren't used in-tree unless it is unavoidable or would be difficult to work around out-of-tree. This one seems pretty straightforward to me. https://reviews.llvm.org/D49486

[PATCH] D49486: [cfe][CMake] Export the clang resource directory

2018-08-09 Thread Philip Pfaffe via Phabricator via cfe-commits
philip.pfaffe added a comment. I had not, but it should work just as well! https://reviews.llvm.org/D49486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49486: [cfe][CMake] Export the clang resource directory

2018-08-09 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added a comment. I’m not opposed to this patch, but is there a real need for this? Have you considered just running clang with the `-print-resource-dir` flag? https://reviews.llvm.org/D49486 ___ cfe-commits mailing list

[PATCH] D49486: [cfe][CMake] Export the clang resource directory

2018-08-09 Thread Philip Pfaffe via Phabricator via cfe-commits
philip.pfaffe added a comment. Ping. https://reviews.llvm.org/D49486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49486: [cfe][CMake] Export the clang resource directory

2018-07-19 Thread Kim Gräsman via Phabricator via cfe-commits
kimgr added a comment. Thank you for doing this, I'm going to guess you have IWYU in mind :-) So as consumers of this, how do you envision we use the new variable? Something like https://stackoverflow.com/a/13429998 to copy the resource dir into our build root, and then an install rule to put

[PATCH] D49486: [cfe][CMake] Export the clang resource directory

2018-07-18 Thread Philip Pfaffe via Phabricator via cfe-commits
philip.pfaffe created this revision. philip.pfaffe added reviewers: mgorny, beanz, gottesmm. Herald added a subscriber: bollu. Out-of-tree tools trying to parse source files need the builtin headers such as `stddef.h`. If the tool isn't installed together with clang, it can't find them