This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE338017: [clangd] Proof-of-concept query iterators for Dex
symbol index (authored by omtcyfz, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49546?vs=157450=157451#toc
Repository:
kbobyrev updated this revision to Diff 157450.
kbobyrev marked 10 inline comments as done.
kbobyrev added a comment.
Address post-lg round of comments.
https://reviews.llvm.org/D49546
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/Iterator.cpp
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg! just a few nits.
Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:109
+private:
+ /// Restores class invariants: each child should point to the same element.
kbobyrev updated this revision to Diff 157447.
kbobyrev added a comment.
Rebase on top of https://reviews.llvm.org/rL337901
https://reviews.llvm.org/D49546
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/Iterator.cpp
kbobyrev updated this revision to Diff 157438.
kbobyrev marked 30 inline comments as done.
kbobyrev added a comment.
Addressed a round of comments: cleaned up the code, improved documentation and
properly introduced such terms like Posting List and Query Tree. Tests are now
more modular and
kbobyrev updated this revision to Diff 157439.
kbobyrev added a comment.
Typo: "Returns false if ..., false otherwise" ->"Returns false if ..., true
otherwise".
https://reviews.llvm.org/D49546
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/Iterator.cpp
ioeric added a comment.
Implementation is in a good shape. I only have nits ;)
Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:18
+namespace clangd {
+namespace dex {
+
Please put all local classes and helpers in an anonymous namespace.
kbobyrev updated this revision to Diff 157208.
kbobyrev retitled this revision from "[clangd] Implement query iterators for
Dex symbol index" to "[clangd] Proof-of-concept query iterators for Dex symbol
index".
kbobyrev edited the summary of this revision.
kbobyrev added a comment.
Choose
