[PATCH] D49580: [clang-format] Adding style option for absolute formatting

2018-08-09 Thread Arnaud Coomans via Phabricator via cfe-commits
acoomans abandoned this revision. acoomans added a comment. Changed approach based on feedback. New changeset: https://reviews.llvm.org/D50535 https://reviews.llvm.org/D49580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

2018-08-02 Thread Jacek Olesiak via Phabricator via cfe-commits
jolesiak added a comment. Thanks! https://reviews.llvm.org/D49580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D49580: [clang-format] Adding style option for absolute formatting

2018-08-01 Thread Arnaud Coomans via cfe-commits
Thanks for the review. I’ll update when I’m back from vacation Arnaud > On Jul 30, 2018, at 6:09 AM, Jacek Olesiak via Phabricator > wrote: > > jolesiak added a comment. > > In https://reviews.llvm.org/D49580#1179924, @djasper wrote: > >> Ok, so IIUC, understanding that @end effective ends

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

2018-07-30 Thread Jacek Olesiak via Phabricator via cfe-commits
jolesiak added a comment. In https://reviews.llvm.org/D49580#1179924, @djasper wrote: > Ok, so IIUC, understanding that @end effective ends a section much like "}" > would address the currently observed problems? I think so. https://reviews.llvm.org/D49580

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

2018-07-30 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added a comment. Ok, so IIUC, understanding that @end effective ends a section much like "}" would address the currently observed problems? https://reviews.llvm.org/D49580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

2018-07-30 Thread Jacek Olesiak via Phabricator via cfe-commits
jolesiak added a comment. First of all, thanks, Arnaud, for looking into this. Let's address the mentioned bug first. Let's assume that we use `IndentReference = Relative`. I think that this particular formatting bug is local (i.e. can be solved while processing a `@protocol` block). Look at

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

2018-07-24 Thread Jacek Olesiak via Phabricator via cfe-commits
jolesiak added a comment. Sorry for the delay, I'll comment on that tomorrow. https://reviews.llvm.org/D49580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

2018-07-23 Thread Arnaud Coomans via Phabricator via cfe-commits
acoomans added a comment. I don't know; I just picked a random bug from the Bugzilla to get myself familiarized with the LLVM codebase :) @jolesiak? https://reviews.llvm.org/D49580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

2018-07-23 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added a comment. In my opinion, this only addresses one edge case where clang-format -lines output is not identical with a full reformatting. I believe they cannot all usefully be avoided. As such, I am unsure that this option carries its weight of making the implementation more

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

2018-07-23 Thread Arnaud Coomans via Phabricator via cfe-commits
acoomans added a comment. Also ping @jolesiak since he initially filed the report https://reviews.llvm.org/D49580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

2018-07-23 Thread Arnaud Coomans via Phabricator via cfe-commits
acoomans added a comment. @djasper I updated the description of the diff. This fixes the issue of `clang-format -lines=x:x` not returning the same results as `clang-format`, while keeping the current behavior as default. https://reviews.llvm.org/D49580

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

2018-07-23 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added a comment. Could you explain what problem this is fixing? https://reviews.llvm.org/D49580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

2018-07-20 Thread Arnaud Coomans via Phabricator via cfe-commits
acoomans updated this revision to Diff 156571. acoomans retitled this revision from "[WIP] Change clang-format to absolute indentation" to "[clang-format] Adding style option for absolute formatting". acoomans edited the summary of this revision. https://reviews.llvm.org/D49580 Files: