[PATCH] D49745: Generate fundamental type info with weak linkage

2018-07-24 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc requested changes to this revision. pcc added a comment. This revision now requires changes to proceed. As I mentioned in https://bugs.llvm.org/show_bug.cgi?id=38281 I don't see a good reason to do this. Also extern_weak is not an appropriate linkage for definitions, only declarations.

[PATCH] D49745: Generate fundamental type info with weak linkage

2018-07-24 Thread Tom Anderson via Phabricator via cfe-commits
thomasanderson created this revision. thomasanderson added a reviewer: pcc. https://reviews.llvm.org/D49745 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/rtti-fundamental.cpp test/CodeGenCXX/windows-itanium-type-info.cpp Index: test/CodeGenCXX/windows-itanium-type-info.cpp