This revision was automatically updated to reflect the committed changes.
Closed by commit rC337944: [clang:sema] de-duplicate getDepthAndIndex helpers
(authored by nickdesaulniers, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49760?vs=157134=157314#toc
Repository:
rC
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D49760#1174141, @nickdesaulniers wrote:
> Thanks for the review. Today is my first day committing to clang!
Welcome :).
LGTM. Feel free to commit this yourself once
nickdesaulniers updated this revision to Diff 157134.
nickdesaulniers added a comment.
- prefer auto when type is specified on RHS of assignment.
Repository:
rC Clang
https://reviews.llvm.org/D49760
Files:
include/clang/Sema/SemaInternal.h
lib/Sema/SemaTemplateDeduction.cpp
nickdesaulniers marked an inline comment as done.
nickdesaulniers added a comment.
Thanks for the review. Today is my first day committing to clang!
Repository:
rC Clang
https://reviews.llvm.org/D49760
___
cfe-commits mailing list
vsk added a comment.
Thanks for doing this!
Comment at: include/clang/Sema/SemaInternal.h:120
+ if (const TemplateTypeParmType *TTP =
+ UPP.first.dyn_cast())
+return std::make_pair(TTP->getDepth(), TTP->getIndex());
Perhaps 'const auto *TTP =
nickdesaulniers created this revision.
nickdesaulniers added reviewers: srhines, pirama.
Herald added a subscriber: cfe-commits.
Continuing off of:
https://reviews.llvm.org/D38382
Fixes:
https://bugs.llvm.org/show_bug.cgi?id=12176
Repository:
rC Clang
https://reviews.llvm.org/D49760
Files:
