This revision was automatically updated to reflect the committed changes.
Closed by commit rL338157: [libc++] Exclude posix_l/strtonum fallback inclusion
for newlib 2.4 (authored by rupprecht, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
rupprecht added a comment.
In https://reviews.llvm.org/D49927#1178659, @ldionne wrote:
> Just to make sure I understand properly: this means we will use newlib's
> implementation of `iswcntrl_l` & friends instead of our own emulation (which
> is an ODR violation currently going unnoticed)? And
jyknight accepted this revision.
jyknight added a comment.
This revision is now accepted and ready to land.
Typo in commit message? They were added to 2.5, not 2.4 (the code is right,
just the comment is wrong).
Repository:
rCXX libc++
https://reviews.llvm.org/D49927
ldionne added a comment.
Just to make sure I understand properly: this means we will use newlib's
implementation of `iswcntrl_l` & friends instead of our own emulation (which is
an ODR violation currently going unnoticed)? And this is OK because newlib
provides `iswcntrl_l` & friends starting
rupprecht created this revision.
rupprecht added reviewers: ldionne, rsmith.
Herald added a reviewer: EricWF.
Herald added subscribers: cfe-commits, christof.
[libc++] Exclude posix_l/strtonum fallback inclusion for newlib > 2.4
r338122 changed the linkage of some methods which revealed an
