[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

This revision was automatically updated to reflect the committed changes. Closed by commit rL338361: [clangd] Report diagnostics even if WantDiags::No AST was reused (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov updated this revision to Diff 158217. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Check for PrevDiagsWereReported Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50045 Files: clangd/TUScheduler.cpp

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:381 + DiagsWereReported = PrevDiagsWereReported; + if (DiagsWereReported) { +// Take a shortcut and don't report the diagnostics, since they

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land. Comment at: clangd/TUScheduler.cpp:381 + DiagsWereReported = PrevDiagsWereReported; + if (DiagsWereReported) { +// Take a shortcut and don't report the

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:379 + +if (DiagsWereReported) { // Take a shortcut and don't build the AST if neither the inputs nor the ilya-biryukov wrote: >

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov updated this revision to Diff 158216. ilya-biryukov added a comment. - Moved early return into the CanReuseAST branch Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50045 Files: clangd/TUScheduler.cpp unittests/clangd/TUSchedulerTests.cpp Index:

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:379 + +if (DiagsWereReported) { // Take a shortcut and don't build the AST if neither the inputs nor the ioeric wrote: > The implicit condition here is that we can reuse AST and

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov updated this revision to Diff 158201. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Added a comment Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50045 Files: clangd/TUScheduler.cpp unittests/clangd/TUSchedulerTests.cpp

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ioeric added a comment. Overall LG, just a suggestion to make the code a bit easier to follow. Comment at: clangd/TUScheduler.cpp:379 + +if (DiagsWereReported) { // Take a shortcut and don't build the AST if neither the inputs nor the The implicit

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov created this revision. ilya-biryukov added a reviewer: ioeric. Herald added subscribers: jfb, arphaman, jkorous, MaskRay, javed.absar. After r338256, clangd stopped reporting diagnostics if WantDiags::No request is followed by a WantDiags::Yes request but the AST can be reused.