mgorny added a comment.
Thank you!
Repository:
rL LLVM
https://reviews.llvm.org/D50171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342897: [python] [tests] Update test_code_completion
(authored by mgorny, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D50171#1236792, @mgorny wrote:
> @ilya-biryukov, gentle ping. I'd like to patch this for 7.0.0 in Gentoo. Do
> you think my patch would be good
mgorny added a comment.
@ilya-biryukov, gentle ping. I'd like to patch this for 7.0.0 in Gentoo. Do you
think my patch would be good enough, or do you expect to submit something else
soonish?
https://reviews.llvm.org/D50171
___
cfe-commits
ilya-biryukov added a comment.
Will take a closer look. Thanks for finding the offending revision.
https://reviews.llvm.org/D50171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
...and unless I'm mistaken, this commit is responsible for both changes (that
is, I need to apply all of this patch to make tests pass at its point).
https://reviews.llvm.org/D50171
___
cfe-commits mailing list
mgorny added a comment.
Apparently the first change changing the completion results is:
commit a408f8d27bfd5bab55c39ef2a6fff6850be4a351
Author: Ilya Biryukov
Date: Tue Apr 24 15:48:53 2018
[CodeComplete] Fix completion at the end of keywords
Summary:
Make
mgorny updated this revision to Diff 164871.
mgorny added a comment.
Ai, sorry about that. Uploaded the proper diff now. I suppose it's not going to
make it for 7.0.0 anymore, so it's not a priority. I'll try to bisect it today
once I finish testing RC3.
https://reviews.llvm.org/D50171
ilya-biryukov added a comment.
Also can't explain why `const` and `volatile` have a different priority now.
The `P::` and `Q::` seem to be completely different completion items from `P`
and `Q` (wildly different priorities suggest they're not the same), can't
explain what caused the first ones
mgorny added a comment.
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D50171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny created this revision.
mgorny added reviewers: ilya-biryukov, arphaman, bkramer, gribozavr.
Update expected completions to match output generated by clang-7.0.
Disclaimer: I have no clue if the results are correct. I'm kinda wondering why
the '::' part is no longer included immediately.
11 matches
Mail list logo
