Meinersbur closed this revision.
Meinersbur added a comment.
Commited as https://reviews.llvm.org/rL342861.
Repository:
rC Clang
https://reviews.llvm.org/D50214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D50214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
Meinersbur added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D50214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: lib/AST/DeclBase.cpp:854-859
+ auto I = Attrs.begin(), E = Attrs.end();
+ for (; I != E; ++I) {
+if (!(*I)->isInherited())
+ break;
+ }
+ Attrs.insert(I, A);
Meinersbur wrote:
> aaron.ballman wrote:
>
Meinersbur added inline comments.
Comment at: lib/AST/DeclBase.cpp:854-859
+ auto I = Attrs.begin(), E = Attrs.end();
+ for (; I != E; ++I) {
+if (!(*I)->isInherited())
+ break;
+ }
+ Attrs.insert(I, A);
aaron.ballman wrote:
> The unfortunate part ab
aaron.ballman added subscribers: rsmith, echristo, dlj, nicholas.
aaron.ballman edited reviewers, added: rsmith; removed: nicholas, dlj, echristo.
aaron.ballman added a comment.
In general, I think this is the right way to go. I've added @rsmith to the
reviewers because I'm curious what his thoug
Meinersbur added a comment.
For this patch the goal is to have the attributes in the AST in an order that
is less surprising to consumers (including out-of-tree). If we change it now,
new/revised code/diagnostics will be written to match this order.
I agree that ideally, most attributes (except
erichkeane added a comment.
IMO, I think this (and the next 2 numerically), show to me that we have too
much dependence on the order of attributes, which all of these show is not a
reliable thing to count on. I quite dislike this as well, and think this is
going to lead us to chasing these sam
Meinersbur created this revision.
Meinersbur added reviewers: hfinkel, aaron.ballman, nicholas, dlj, echristo,
erichkeane.
Currently, attributes from previous declarations ('inherited attributes') are
added to the end of a declaration's list of attributes. Before r338800, the
attribute list was
