justice_adams added a comment.
@stella.stamenova @thakis Thanks for the feedback all, I will go ahead and make
this change to the way I'm representing directories, open a new diff for
review, and add you as a reviewer.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
stella.stamenova added a comment.
@thakis Thanks for the information, I had actually missed that.
The way this test is written, it needs to use a directory (so %T is "correct"),
but to remove %T, it could be changed to use something like
```%t.doesnotexist.somename``` instead. If you feel
thakis added a comment.
(fwiw using %T is discouraged nowadays, see
https://llvm.org/docs/CommandGuide/lit.html#pre-defined-substitutions /
https://reviews.llvm.org/D35396 )
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D50563/new/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC352252: Fixed frontend clang tests in windows read-only
container (authored by stella.stamenova, committed by ).
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D50563/new/
justice_adams added a comment.
@stella.stamenova thanks for the review. I don't have commit access, would you
mind committing this for me?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D50563/new/
https://reviews.llvm.org/D50563
___
justice_adams added a comment.
@stella.stamenova Thanks for the input, what about now?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D50563/new/
https://reviews.llvm.org/D50563
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
justice_adams updated this revision to Diff 183197.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D50563/new/
https://reviews.llvm.org/D50563
Files:
test/Frontend/output-failures.c
test/Frontend/stats-file.c
Index: test/Frontend/stats-file.c
stella.stamenova requested changes to this revision.
stella.stamenova added a comment.
This revision now requires changes to proceed.
Thanks. You have to change a couple of the locations to '%T' though - '%t' is a
file and '%T' is a directory - and you're using '%t' as a directory in a couple
justice_adams added a comment.
@stella.stamenova Good suggestion, I think you are right. I have updated the
diff to use %t, that way any end-users can control the way their lit test work
in a read-only mount by simply altering the test_exec_root in their config
CHANGES SINCE LAST ACTION
justice_adams updated this revision to Diff 183170.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D50563/new/
https://reviews.llvm.org/D50563
Files:
test/Frontend/output-failures.c
test/Frontend/stats-file.c
Index: test/Frontend/stats-file.c
stella.stamenova requested changes to this revision.
stella.stamenova added inline comments.
This revision now requires changes to proceed.
Comment at: test/Frontend/output-failures.c:1
-// RUN: not %clang_cc1 -emit-llvm -o %S/doesnotexist/somename %s 2> %t
-// RUN: FileCheck
justice_adams added a comment.
@cfe-commits Re-pinging this group to request a review on this patch
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D50563/new/
https://reviews.llvm.org/D50563
___
cfe-commits mailing list
justice_adams added a comment.
@cfe-commits ping requesting a review on this patch
https://reviews.llvm.org/D50563
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
justice_adams created this revision.
justice_adams added a project: clang.
When mounting LLVM source into a windows container in read-only mode, certain
tests fail. Ideally, we want all these tests to pass so that developers can
mount the same source folder into multiple (windows) containers
14 matches
Mail list logo
