[PATCH] D50763: [Parser] Refactor and fix bugs in late-parsing

2021-04-10 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a comment. @hamzasood, I suppose this is still worth pursuing. Could you address the comment? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50763/new/ https://reviews.llvm.org/D50763 ___

[PATCH] D50763: [Parser] Refactor and fix bugs in late-parsing

2019-07-09 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Herald added a project: clang. Comment at: lib/Parse/ParseCXXInlineMethods.cpp:266 +public: + UseCachedTokensRAII(Parser , CachedTokens , const void *Data) + : Self(Self), Data(Data) { Can you pass ownership of the cached

[PATCH] D50763: [Parser] Refactor and fix bugs in late-parsing

2018-08-15 Thread Hamza Sood via Phabricator via cfe-commits
hamzasood created this revision. hamzasood added reviewers: erichkeane, v.g.vassilev, malcolm.parsons, rsmith. Herald added a reviewer: javed.absar. Herald added subscribers: cfe-commits, kristof.beyls, eraman. This patch extracts the eof/stop token pattern used in late-parsing to a re-usable